Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add alternative methods to create tasks and results separately #204

Merged
merged 2 commits into from
May 4, 2023
Merged

feat: Add alternative methods to create tasks and results separately #204

merged 2 commits into from
May 4, 2023

Conversation

aneojgurhem
Copy link
Contributor

Adds rpc methods in TasksService, ResultsService and AgentService for task and result dissociation.

@aneojgurhem aneojgurhem self-assigned this Mar 30, 2023
@aneojgurhem aneojgurhem requested a review from ngruelaneo March 30, 2023 06:23
@aneojgurhem aneojgurhem marked this pull request as draft March 30, 2023 06:24
@aneojgurhem aneojgurhem force-pushed the jg/taskresultdissociation branch from 2e9e5bf to 359c033 Compare April 3, 2023 05:31
@github-actions
Copy link

github-actions bot commented Apr 3, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
505 456 90% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f099712 by action🐍

@aneojgurhem aneojgurhem force-pushed the jg/taskresultdissociation branch 2 times, most recently from 1f4ce01 to 3a3b322 Compare April 3, 2023 15:13
lemaitre-aneo
lemaitre-aneo reviewed Apr 5, 2023
View reviewed changes
Protos/V1/agent_common.proto Show resolved Hide resolved
Protos/V1/agent_common.proto Outdated Show resolved Hide resolved
Protos/V1/agent_common.proto Outdated Show resolved Hide resolved
Protos/V1/objects.proto Outdated Show resolved Hide resolved
Protos/V1/result_status.proto Outdated Show resolved Hide resolved
Protos/V1/results_common.proto Outdated Show resolved Hide resolved
Protos/V1/results_common.proto Outdated Show resolved Hide resolved
Protos/V1/results_common.proto Outdated Show resolved Hide resolved
Protos/V1/results_service.proto Outdated Show resolved Hide resolved
Protos/V1/tasks_common.proto Outdated Show resolved Hide resolved
@aneojgurhem aneojgurhem force-pushed the jg/taskresultdissociation branch from bbe9398 to db6ef03 Compare April 5, 2023 15:53
dbrasseur-aneo
dbrasseur-aneo reviewed Apr 5, 2023
View reviewed changes
Protos/V1/agent_common.proto Outdated Show resolved Hide resolved
Protos/V1/agent_common.proto Show resolved Hide resolved
Protos/V1/agent_common.proto Outdated Show resolved Hide resolved
Protos/V1/agent_common.proto Outdated Show resolved Hide resolved
Protos/V1/agent_common.proto Outdated Show resolved Hide resolved
Protos/V1/results_common.proto Show resolved Hide resolved
Protos/V1/submitter_common.proto Outdated Show resolved Hide resolved
Protos/V1/submitter_common.proto Outdated Show resolved Hide resolved
Protos/V1/tasks_common.proto Outdated Show resolved Hide resolved
@aneojgurhem aneojgurhem force-pushed the jg/taskresultdissociation branch from 79ea51f to ed470c0 Compare April 7, 2023 13:13
@aneojgurhem aneojgurhem force-pushed the jg/taskresultdissociation branch 3 times, most recently from c786986 to 2524297 Compare April 26, 2023 05:21
@aneojgurhem aneojgurhem force-pushed the jg/taskresultdissociation branch 5 times, most recently from 36e4a2e to 67a953e Compare May 3, 2023 10:21
@aneojgurhem aneojgurhem marked this pull request as ready for review May 3, 2023 14:55
lemaitre-aneo
lemaitre-aneo reviewed May 4, 2023
View reviewed changes
Protos/V1/agent_common.proto Show resolved Hide resolved
Protos/V1/agent_common.proto Outdated Show resolved Hide resolved
Protos/V1/agent_common.proto Show resolved Hide resolved
Protos/V1/agent_common.proto Show resolved Hide resolved
Protos/V1/agent_common.proto Show resolved Hide resolved
Protos/V1/results_common.proto Outdated Show resolved Hide resolved
Protos/V1/results_service.proto Show resolved Hide resolved
packages/csharp/ArmoniK.Api.Client/ResultsClientExt.cs Show resolved Hide resolved
packages/csharp/ArmoniK.Api.Client/ResultsClientExt.cs Show resolved Hide resolved
@aneojgurhem aneojgurhem force-pushed the jg/taskresultdissociation branch from 67a953e to 46cab83 Compare May 4, 2023 08:34
@aneojgurhem aneojgurhem force-pushed the jg/taskresultdissociation branch from 46cab83 to d116a35 Compare May 4, 2023 08:36
@aneojgurhem aneojgurhem mentioned this pull request May 4, 2023
Open
@aneojgurhem @lemaitre-aneo
docs: some improvements
f099712 
Co-authored-by: lemaitre-aneo <[email protected]>
@aneojgurhem aneojgurhem mentioned this pull request May 4, 2023
Closed
@aneojgurhem aneojgurhem merged commit 74bbbc4 into main May 4, 2023
@aneojgurhem aneojgurhem deleted the jg/taskresultdissociation branch May 4, 2023 15:31
ddiakiteaneo pushed a commit that referenced this pull request Jun 19, 2023
@aneojgurhem
feat: Add alternative methods to create tasks and results separately (#…
3f7c041 
…204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemaitre-aneo lemaitre-aneo lemaitre-aneo approved these changes

@esoubiran-aneo esoubiran-aneo Awaiting requested review from esoubiran-aneo

@ngruelaneo ngruelaneo Awaiting requested review from ngruelaneo

@dbrasseur-aneo dbrasseur-aneo Awaiting requested review from dbrasseur-aneo

Assignees

@aneojgurhem aneojgurhem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aneojgurhem @lemaitre-aneo @dbrasseur-aneo