feat: Add Task List and filters to Python #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneojgurhem
reviewed
Sep 20, 2023
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
aneojgurhem
reviewed
Sep 22, 2023
dbrasseur-aneo
requested review from
ngruelaneo,
qdelamea-aneo and
aneojgurhem
dbrasseur-aneo
changed the title
aneojgurhem
reviewed
Sep 22, 2023
aneojgurhem
reviewed
Sep 22, 2023
dbrasseur-aneo
force-pushed
the
db/addTaskListPython
branch
from
389a4c3 to
406eda9
Compare
dbrasseur-aneo
force-pushed
the
db/addTaskListPython
branch
from
51c1e9f to
bae77f0
Compare
|
|
aneojgurhem
previously approved these changes
Sep 25, 2023
ngruelaneo
reviewed
Sep 25, 2023
| @@ -32,7 +32,7 @@ mkdir -p $ARMONIK_WORKER $ARMONIK_CLIENT $ARMONIK_COMMON $PACKAGE_PATH | |||
| python -m pip install --upgrade pip | |||
| python -m venv $PYTHON_VENV | |||
| source $PYTHON_VENV/bin/activate | |||
| python -m pip install build grpcio grpcio-tools click pytest setuptools_scm[toml] | |||
| python -m pip install build grpcio==1.56.2 grpcio-tools==1.56.2 click pytest setuptools_scm[toml] | |||
There was a problem hiding this comment.
Can you add a comment explaining why the grpc version is fixed ?
ngruelaneo
requested changes
Sep 25, 2023
| NotImplementedError if the given operator is not available for the given class | ||
| """ | ||
| if self.is_true_conjunction() or self.is_true_disjunction(): | ||
| raise Exception(f"Cannot apply operator to a disjunction or a conjunction") |
There was a problem hiding this comment.
you don't knee a fstring here
| """ | ||
| if self.__class__.value_type_ is None or isinstance(value, self.__class__.value_type_): | ||
| return | ||
| raise Exception(f"Expected value type {str(self.__class__.value_type_)} for field {str(self.field)}, got {str(type(value))} instead") |
There was a problem hiding this comment.
it is a bad idea to use fstring in exception:
| raise Exception(f"Cannot apply operator to a disjunction or a conjunction") | ||
| self._verify_value(value) | ||
| if operator is None: | ||
| raise NotImplementedError(f"Operator {operator_str} is not available for {self.__class__.__name__}") |
ngruelaneo
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.