fix: Agent/Worker comm using files in Python and Cpp #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrasseur-aneo
force-pushed
the
db/dataFromFilesCpp
branch
from
5093f87 to
b39d84f
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
dbrasseur-aneo
changed the title
|
Cla bot not giving the comment... |
aneojgurhem
reviewed
Sep 27, 2023
| @@ -89,7 +84,8 @@ class TaskHandler { | |||
| * @param data The result data | |||
| * @return A future containing a vector of ResultReply | |||
| */ | |||
| std::future<armonik::api::grpc::v1::agent::ResultReply> send_result(std::string key, absl::string_view data); | |||
| std::future<armonik::api::grpc::v1::agent::NotifyResultDataResponse> send_result(std::string key, | |||
There was a problem hiding this comment.
It is unfortunate that it changes the API. I think you should wrap this message somehow
There was a problem hiding this comment.
I'd return nothing and throw if there is an issue
aneojgurhem
reviewed
Sep 27, 2023
There was a problem hiding this comment.
why does this change in this PR ?
aneojgurhem
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.