Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added list and delete results to cpp #423

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat: added list and delete results to cpp #423

merged 3 commits into from
Oct 3, 2023

Conversation

dbrasseur-aneo
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
709 643 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: de16faa by action🐍

aneojgurhem
aneojgurhem requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@aneojgurhem aneojgurhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd target main, change versions two and make release on the branch

@dbrasseur-aneo
Copy link
Contributor Author

I'd target main, change versions two and make release on the branch

I need the feature for a version before the agent-worker communication changes...

@aneojgurhem
Copy link
Contributor

aneojgurhem commented Oct 3, 2023 •
edited
Loading

I'd target main, change versions two and make release on the branch

I need the feature for a version before the agent-worker communication changes...

That's why I said:

  • modify version on this branch (to 3.13.1)
  • make release on the branch
  • merge into main

@dbrasseur-aneo
Copy link
Contributor Author

I'd target main, change versions two and make release on the branch

I need the feature for a version before the agent-worker communication changes...

That's why I said:

  • modify version on this branch (to 3.13.1)
  • make release on the branch
  • merge into main

Gotcha, though wouldn't it useful to have a 3.13.x branch if we need further developments on 3.13 ?

@dbrasseur-aneo dbrasseur-aneo changed the base branch from 3.13.x to main October 3, 2023 08:07
@aneojgurhem
Copy link
Contributor

I'd target main, change versions two and make release on the branch

I'd target main, change versions two and make release on the branch

I need the feature for a version before the agent-worker communication changes...

That's why I said on the branch

I'd target main, change versions two and make release on the branch

I need the feature for a version before the agent-worker communication changes...

That's why I said:

  • modify version on this branch (to 3.13.1)
  • make release on the branch
  • merge into main

Gotcha, though wouldn't it useful to have a 3.13.x branch if we need further developments on 3.13 ?

We can just checkout from tag. No need for an explicit branch

@aneojgurhem aneojgurhem merged commit 76b5360 into main Oct 3, 2023
43 checks passed
@aneojgurhem aneojgurhem deleted the db/cppResultsDelete branch October 3, 2023 12:35
@dbrasseur-aneo dbrasseur-aneo restored the db/cppResultsDelete branch October 9, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneojgurhem aneojgurhem aneojgurhem approved these changes

@lemaitre-aneo lemaitre-aneo Awaiting requested review from lemaitre-aneo

@ddiakiteaneo ddiakiteaneo Awaiting requested review from ddiakiteaneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrasseur-aneo @aneojgurhem