feat: Update Python API: support upload decoupling #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qdelamea-aneo
commented
Dec 20, 2023
qdelamea-aneo
commented
- Python API update Task and Result service
- Python API update Results Tasks Events Partitions and Versions services
- Python API update task handler
|
|
qdelamea-aneo
requested review from
dbrasseur-aneo,
jeremyzyngeraneo,
aneojgurhem,
lemaitre-aneo and
ngruelaneo
aneojgurhem
reviewed
Dec 20, 2023
aneojgurhem
reviewed
Dec 20, 2023
ngruelaneo
reviewed
Dec 21, 2023
ngruelaneo
reviewed
Dec 21, 2023
| page=page, | ||
| page_size=page_size, | ||
| filters=cast(rawFilters, task_filter.to_disjunction().to_message()), | ||
| filters=cast(rawFilters, session_filter.to_disjunction().to_message()), | ||
| sort=ListSessionsRequest.Sort(field=cast(SessionField, sort_field.field), direction=sort_direction), | ||
| ) | ||
| list_response : ListSessionsResponse = self._client.ListSessions(request) |
There was a problem hiding this comment.
Why do you remove the type line 79 and keep it here?
ngruelaneo
reviewed
Dec 21, 2023
qdelamea-aneo
force-pushed
the
qd/api.python
branch
from
bc536b3 to
f89b0ac
Compare
qdelamea-aneo
force-pushed
the
qd/api.python
branch
from
1e9d971 to
cbea272
Compare
ngruelaneo
reviewed
Jan 3, 2024
| @@ -33,7 +33,7 @@ python -m pip install --upgrade pip | |||
| python -m venv $PYTHON_VENV | |||
| source $PYTHON_VENV/bin/activate | |||
| # We need to fix grpc to 1.56 until this bug is solved : https://github.com/grpc/grpc/issues/34305 | |||
| python -m pip install build grpcio==1.56.2 grpcio-tools==1.56.2 click pytest setuptools_scm[toml] | |||
| python -m pip install build grpcio==1.56.2 grpcio-tools==1.56.2 click pytest setuptools_scm[toml] ruff requests | |||
There was a problem hiding this comment.
pytest, setuptool_scm, ruff and requests should not be here but in the pyproject.toml file
| @@ -0,0 +1,21 @@ | |||
| from typing import cast, List, Tuple | |||
.github/workflows/ci.yml
Outdated
| run: | | ||
| cd ../csharp/ArmoniK.Api.Mock | ||
| nohup dotnet run > /dev/null 2>&1 & | ||
| sleep 10 |
There was a problem hiding this comment.
there are some chance that you have to increase the waiting time for the service to be started. On my wsl, it take at least 20 seconds to start completely. The vm provided by github are not very veloce either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.