fix: Default value for Task Output when creating task (#702)

aneoconsulting · May 27, 2024 · 4a53e2e · 4a53e2e
2 parents c1a6a58 + f6d4caa
commit 4a53e2e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/Common/src/Storage/TaskLifeCycleHelper.cs b/Common/src/Storage/TaskLifeCycleHelper.cs
@@ -146,8 +146,8 @@ public static async Task CreateTasks(ITaskTable                       taskTable,
                                                                                     TaskStatus.Creating,
                                                                                     request.Options ??
                                                                                     throw new ArmoniKException("Task Options should not be null here"),
-                                                                                    new Output(OutputStatus.Error,
-                                                                                               "Task Options should not be null here"))),
+                                                                                    new Output(OutputStatus.Success,
+                                                                                               ""))),
                                 cancellationToken)
                    .ConfigureAwait(false);
 

diff --git a/Tests/Stream/Client/StreamWrapperTests.cs b/Tests/Stream/Client/StreamWrapperTests.cs
@@ -214,6 +214,12 @@ public async Task<int> Square(int input)
                                                                })
                                 .ConfigureAwait(false);
 
+    await client_!.WaitForAvailabilityAsync(new ResultRequest
+                                            {
+                                              ResultId = expectedOutput,
+                                              Session  = sessionId,
+                                            });
+
     var resultRequest = new TaskOutputRequest
                         {
                           TaskId  = taskIds.Single(),
@@ -274,6 +280,16 @@ public async Task TaskFailed()
                                                                taskRequests)
                                 .ConfigureAwait(false);
 
+    foreach (var request in taskRequests)
+    {
+      await client_!.WaitForAvailabilityAsync(new ResultRequest
+                                              {
+                                                ResultId = request.ExpectedOutputKeys.Single(),
+                                                Session  = sessionId,
+                                              })
+                    .ConfigureAwait(false);
+    }
+
     var taskOutput = taskIds.Select(id =>
                                     {
                                       var resultRequest = new TaskOutputRequest