perf: retrieve chunk size only once

aneoconsulting · Dec 15, 2023 · caed497 · caed497
1 parent cc25d0c
commit caed497
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/Client/src/Common/Submitter/BaseClientSubmitter.cs b/Client/src/Common/Submitter/BaseClientSubmitter.cs
@@ -23,7 +23,6 @@
 using System.Threading.Tasks;
 
 using ArmoniK.Api.Client;
-using ArmoniK.Api.Client.Submitter;
 using ArmoniK.Api.Common.Utils;
 using ArmoniK.Api.gRPC.V1;
 using ArmoniK.Api.gRPC.V1.Results;
@@ -63,6 +62,8 @@ public abstract class BaseClientSubmitter<T>
   /// </summary>
   private readonly int chunkSubmitSize_;
 
+  private readonly int configuration_;
+
   private readonly Properties properties_;
 
   /// <summary>
@@ -93,6 +94,9 @@ protected BaseClientSubmitter(Properties     properties,
                                          {
                                            TaskOptions.PartitionId,
                                          });
+
+    configuration_ = ChannelPool.WithChannel(channel => new Results.ResultsClient(channel).GetServiceConfiguration(new Empty())
+                                                                                          .DataChunkMaxSize);
   }
 
   private ILoggerFactory LoggerFactory { get; }
@@ -288,9 +292,6 @@ private IEnumerable<string> ChunkSubmitTasksWithDependencies(IEnumerable<Tuple<s
     var tasks          = new List<SubmitTasksRequest.Types.TaskCreation>();
     var tasksSubmitted = new List<string>();
 
-    var configuration = ChannelPool.WithChannel(channel => new Results.ResultsClient(channel).GetServiceConfiguration(new Empty())
-                                                                                             .DataChunkMaxSize);
-
     foreach (var (resultId, payload, dependencies) in payloadsWithDependencies)
     {
       for (var nbRetry = 0; nbRetry < maxRetries; nbRetry++)
@@ -302,7 +303,7 @@ private IEnumerable<string> ChunkSubmitTasksWithDependencies(IEnumerable<Tuple<s
         {
           // todo: migrate to ArmoniK.Api
           string payloadId;
-          if (payload.Length > configuration)
+          if (payload.Length > configuration_)
           {
             payloadId = resultsClient.CreateResultsMetaData(new CreateResultsMetaDataRequest
                                                             {