refactor: Consolidated SessionServices into common #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrasseur-aneo
force-pushed
the
db/reduceRepetition
branch
from
f7a47c5 to
046dafe
Compare
| Logger = loggerFactory?.CreateLogger<T>(); | ||
| chunkSubmitSize_ = chunkSubmitSize; | ||
| } | ||
| public readonly ChannelPool ChannelPool; |
There was a problem hiding this comment.
Why do you need the channel pool to be public?
|
|
||
|
|
||
| #pragma warning restore CS1591 | ||
| public readonly TaskOptions TaskOptions; |
There was a problem hiding this comment.
Why do we need to store the task options? That is the role of core, isn't it?
| Seconds = 300, | ||
| }, | ||
| MaxRetries = 3, | ||
| Priority = 1, |
There was a problem hiding this comment.
I think a Priority of 2 would be better by default (2 is neither the minimum, nor the maximum).
Comment on lines
947
to
953
| partitions ?? | ||
| (string.IsNullOrEmpty(defaultTaskOptions.PartitionId) | ||
| ? Enumerable.Empty<string>() | ||
| : new List<string> | ||
| { | ||
| defaultTaskOptions.PartitionId, | ||
| }), |
There was a problem hiding this comment.
That's core responsibility
aneojgurhem
reviewed
Jul 10, 2023
| public SessionService CreateSession(TaskOptions taskOptions = null) | ||
| { | ||
| ControlPlaneConnection(); | ||
|
|
||
| return new SessionService(GrpcPool, | ||
| LoggerFactory, | ||
| taskOptions); | ||
| taskOptions ?? SessionService.GetDefaultTaskOptions(EngineType.Symphony), |
There was a problem hiding this comment.
Options are not impacted in other clients ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.