refactor: remove submitter from Wait for results method in client part #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneojgurhem
force-pushed
the
me/removeSubmitterInWaitResults
branch
from
a990e11 to
63c6eb3
Compare
aneojgurhem
force-pushed
the
me/removeSubmitterInWaitResults
branch
from
63c6eb3 to
1aafa59
Compare
|
Issue here comes from a bug in core ; aneoconsulting/ArmoniK.Core#558. |
ngruelaneo
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to remove the submitter from the method GetResult that waits for the results before getting them. The implementation for WaitForResults used is the same in ArmoniK.Api. It uses the events API. Tests did not always pass. There is some unkown and "random" reason that causes the tests to crash sometimes, given that the stream received from the events api was correctly handled.