refactor: remove submitter from chunk submit with dependencies method #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneojgurhem
force-pushed
the
me/removeSubmitterInSubmit
branch
from
a07c6f9 to
03a8090
Compare
aneojgurhem
force-pushed
the
me/removeSubmitterInSubmit
branch
from
4d82f29 to
cc25d0c
Compare
|
Most likely blocked by: grpc/grpc-dotnet#1778 |
lemaitre-aneo
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft for removing the submitter service from the method chunkSubmitWithDependencies. It is the same implementation used in ArmoniK.Core. What is missed in this draft is to label the payloads.
Another more relevant improvements are possible: submit tasks in a batch not one by one