Fl/connection pool #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
|
This continues to fix the GoAway issue. Preliminary tests show a 20% improvements on performance compared to the mutex. |
This was
linked to
issues
Oct 17, 2022
ddubuc
reviewed
Oct 17, 2022
| } | ||
|
|
||
| channel = channelFactory_(); | ||
| logger_?.LogInformation("Created and acquired new channel {channel} from pool", |
There was a problem hiding this comment.
LogDebug rather than LogInformation ?
There was a problem hiding this comment.
Those events should be really rare as they happen only when the pool is empty. I think it is useful to have the log at the information level.
Client/src/ArmoniK.DevelopmentKit.Client.Common/Submitter/ClientServiceConnector.cs
Show resolved
Hide resolved
aneojgurhem
requested changes
Oct 17, 2022
Client/src/ArmoniK.DevelopmentKit.Client.Common/Submitter/BaseClientSubmitter.cs
Outdated
Show resolved
Hide resolved
Client/src/ArmoniK.DevelopmentKit.Client.Common/Submitter/ClientServiceConnector.cs
Show resolved
Hide resolved
Client/src/ArmoniK.DevelopmentKit.Client.Common/Submitter/ClientServiceConnector.cs
Show resolved
Hide resolved
Client/src/ArmoniK.DevelopmentKit.Client.Common/Submitter/ClientServiceConnector.cs
Show resolved
Hide resolved
aneojgurhem
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a connection pool and remove the mutex in order to fix some "Go Away" errors while improving performance.