Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kubernetes manifests to deploy a minimum ArmoniK installation #167

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aneojgurhem
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lemaitre-aneo lemaitre-aneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a single manifest. This would be simpler to do with aneoconsulting/ArmoniK.Core#766

- containerPort: 1080
name: submitter
# docker inspect armonik.control.submitter | jq -r '.[].Config.Env | map(split("=") | {name:.[0], value:.[1]})' | yq -P
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a core-configmap

Comment on lines +79 to +110
set $seq_upstream http://10.43.150.249:8080;
location = /seq {
rewrite ^ $scheme://$http_host/seq/ permanent;
}
location /seq/ {
proxy_set_header Host $http_host;
proxy_set_header Accept-Encoding "";
rewrite ^/seq/(.*) /$1 break;
proxy_pass $seq_upstream$uri$is_args$args;
sub_filter '<head>' '<head><base href="${scheme}://${http_host}/seq/">';
sub_filter_once on;
proxy_hide_header content-security-policy;
}
set $grafana_upstream http://10.43.130.56:3000;
location = /grafana {
rewrite ^ $scheme://$http_host/grafana/ permanent;
}
location /grafana/ {
rewrite ^/grafana/(.*) /$1 break;
proxy_set_header Host $http_host;
proxy_pass $grafana_upstream$uri$is_args$args;
sub_filter '<head>' '<head><base href="${scheme}://${http_host}/grafana/">';
sub_filter_once on;
proxy_intercept_errors on;
error_page 301 302 307 =302 ${scheme}://${http_host}${upstream_http_location};
}
location /grafana/api/live {
rewrite ^/grafana/(.*) /$1 break;
proxy_http_version 1.1;
proxy_set_header Host $http_host;
proxy_pass $grafana_upstream$uri$is_args$args;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove this, or put the domain names if you want to keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants