Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add module to get a Key from the GCP Project #84

Open
wants to merge 10 commits into
base: revamp-cloud
Choose a base branch
from

Conversation

hbitoun-aneo
Copy link
Contributor

No description provided.

@iadjadj iadjadj closed this Aug 31, 2023
@iadjadj iadjadj reopened this Aug 31, 2023
@iadjadj iadjadj changed the title feat: Add module to get a Key from the GCP project feat: Add module to get a Key from the GCP Project Aug 31, 2023
Copy link
Contributor

@lemaitre-aneo lemaitre-aneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module should behave similarly than the kms module (except for resource creation). In particular, it should support multiple keys per key ring, and have the same output as the kms module.

Copy link
Contributor

@ftchawe-aneo ftchawe-aneo Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation should highlight the purpose of the module in the framework of ArmoniK

Copy link
Contributor

@lemaitre-aneo lemaitre-aneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of the name of the module. I would prefer to have kms at the beginning of the name.

Here are some name suggestions (in order of personal preference):

  • kms-get
  • kms-data
  • kms-existing
  • kms-import
  • kms-external

type = string
variable "crypto_key_names" {
description = "The names of the crypto keys to retrieve from the GCP project."
type = list(string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type = list(string)
type = set(string)

@@ -1,4 +1,19 @@
output "my_crypto_key_output" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
output "my_crypto_key_output" {
output "cyprto_keys" {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing output compared to to the resource module:

output "crypto_key_ids" {
  description = "The Map of the created crypto keys."
  value       = { for key, value in google_kms_crypto_key.keys : key => value.id }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants