Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full review of README for discussion #1230

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

ddubuc
Copy link
Contributor

@ddubuc ddubuc commented Oct 30, 2023

PR only for discussion around the main customer README

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ngruelaneo ngruelaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Readme is clearly much better than the previous one. Thanks for it.

<em>ArmoniK</em> is a high throughput compute grid project using Kubernetes. The project provides a reference
architecture that can be used to build and adapt a modern high throughput compute solution on-premise or using Cloud
services, allowing users to submit high volumes of short and long-running tasks and scaling environments dynamically.
ArmoniK is an open-source high throughput compute grid built on Kubernetes. It provides a scalable and robust framework for running large volumes of compute tasks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that insisting on Kubernetes is a good idea. We can present that as an example but for some client using Kubernetes and presenting that as a requirement could be problematic.


Please, read [documentation](https://aneoconsulting.github.io/ArmoniK/) for more information about ArmoniK.
ArmoniK allows users to submit high volumes of short and long-running compute tasks, while dynamically scaling the underlying infrastructure to meet demand. It is designed as a reference architecture that can be deployed on-premise or in the cloud.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personnaly I understand this sentence, the last one, as ArmoniK is an infrastructure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should add a few words about scheduling and resiliency which are our main points that we present everywhere

Please, read [documentation](https://aneoconsulting.github.io/ArmoniK/) for more information about ArmoniK.
ArmoniK allows users to submit high volumes of short and long-running compute tasks, while dynamically scaling the underlying infrastructure to meet demand. It is designed as a reference architecture that can be deployed on-premise or in the cloud.

The project aims to provide a modern, Kubernetes-native solution for high performance computing applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first remark, too much emphase on Kubernetes


## When should I use ArmoniK?

ArmoniK is designed for workloads that require:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not necessarily all of them at the same time)

## Features

- Horizontally scalable architecture
- gRPC APIs for task management (11 language clients)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- gRPC APIs for task management (11 language clients)
- gRPC APIs for task management (11 potential language clients, as of today 4 of them are officially supported)
)


## Acknowledge
The latest ArmoniK releases are available on [GitHub](https://github.com/aneoconsulting/ArmoniK/releases) and [Docker Hub](https://hub.docker.com/u/dockerhubaneo).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The latest ArmoniK releases are available on [GitHub](https://github.com/aneoconsulting/ArmoniK/releases) and [Docker Hub](https://hub.docker.com/u/dockerhubaneo).
The latest ArmoniK releases are available on [GitHub](https://github.com/aneoconsulting/ArmoniK/releases) and the associated containers on [Docker Hub](https://hub.docker.com/u/dockerhubaneo).


Performance benchmarks for ArmoniK are available here:

[Benchmark results](https://aneoconsulting.github.io/ArmoniK/benchmarking/test-plan/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally obsolete and not maintain. I will not mention it is until it up to date.


[Organization 1]: https://armonik.fr
[Organization 2]: https://aneo.fr
[Blog]: Soon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Blog]: Soon
[Blog]: https://www.armonik.fr/news

[Organization 1]: https://armonik.fr
[Organization 2]: https://aneo.fr
[Blog]: Soon
[YouTube videos]: https://example.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does not exist this should be erased

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Contributor

@aneojgurhem aneojgurhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a great improvement to the Readme ! Thank you !


Please, read [documentation](https://aneoconsulting.github.io/ArmoniK/) for more information about ArmoniK.
ArmoniK allows users to submit high volumes of short and long-running compute tasks, while dynamically scaling the underlying infrastructure to meet demand. It is designed as a reference architecture that can be deployed on-premise or in the cloud.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should add a few words about scheduling and resiliency which are our main points that we present everywhere


Get started with ArmoniK by following the quickstart guide:

[Quickstart guide](https://armonik.readthedocs.io/en/latest/installation/linux/deployment/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a no-go. It does not work !

👉 [ArmoniK Versions](https://aneoconsulting.github.io/ArmoniK/armonik#versions)
👉 [ArmoniK Installation](https://aneoconsulting.github.io/ArmoniK/installation)
👉 [ArmoniK Configuration](https://aneoconsulting.github.io/ArmoniK/guide/how-to/how-to-configure-authentication)
👉 [ArmoniK Performance](https://aneoconsulting.github.io/ArmoniK/benchmarking/test-plan)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this mention as stated above

[Organization 1]: https://armonik.fr
[Organization 2]: https://aneo.fr
[Blog]: Soon
[YouTube videos]: https://example.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

[Organization 1]: https://armonik.fr
[Organization 2]: https://aneo.fr
[Blog]: Soon
[YouTube videos]: https://example.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[YouTube videos]: https://example.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants