Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parametrization of MongoDB persistence for localhost and GCP #1303

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

tschneider-aneo
Copy link
Contributor

@tschneider-aneo tschneider-aneo commented Jul 22, 2024

Motivation

Based on the new feature introduced by aneoconsulting/ArmoniK.Infra#153, this PR enables different persistence configuration for both localhost and GCP deployments, as it is already done for AWS.

Description

It includes a new object persistent_volume in the mongodb variable. If it is null, persistence is disabled as it was before, else, persistence is enabled under the condition that the configuration provided fits you cluster.

Testing

Deployed on GCP and localhost.

Impact

More flexibility with MongoDB persistence for GCP and localhost.

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

Copy link

@tschneider-aneo tschneider-aneo force-pushed the ts/parametrize-persistence-localhost-gcp branch 2 times, most recently from a1a278d to ffc4740 Compare January 23, 2025 11:14
@tschneider-aneo tschneider-aneo changed the title feat: Parametrization of persistence for localhost and GCP deployments feat: Parametrization of MongoDB persistence for localhost and GCP Jan 23, 2025
@tschneider-aneo tschneider-aneo marked this pull request as ready for review January 23, 2025 12:58
@tschneider-aneo tschneider-aneo force-pushed the ts/parametrize-persistence-localhost-gcp branch from ffc4740 to 680ed49 Compare January 23, 2025 13:00
@ngruelaneo ngruelaneo merged commit 66c82aa into main Jan 23, 2025
17 checks passed
@ngruelaneo ngruelaneo deleted the ts/parametrize-persistence-localhost-gcp branch January 23, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants