Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: windows node pool creation #1313

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

jdongo-aneo
Copy link
Contributor

@jdongo-aneo jdongo-aneo commented Aug 21, 2024

This is to support the creation of a windows node pool to be able to execute the control_plane and the compute plane on windows

@jdongo-aneo
Copy link
Contributor Author

Able to deploy the windows node pool.

Fail to run windows containers on the nodes due to the following issue:
Warning FailedCreatePodSandBox 2m6s
kubelet Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "f0f045dbeafd907a2852aee312256d0375de08d465da6275285e5ad27a580c4e": plugin type="vpc-bridge" name="vpc" failed (add): failed to parse Kubernetes args: failed to get pod IP address control-plane-5d65cdf6dc-wr9gs: error executing k8s connector: error executing connector binary: exit status 1 with execution error: pod control-plane-5d65cdf6dc-wr9gs does not have label vpc.amazonaws.com/PrivateIPv4Address

@jdongo-aneo jdongo-aneo self-assigned this Aug 21, 2024
Copy link

@jdongo-aneo jdongo-aneo marked this pull request as ready for review November 28, 2024 15:32

# Logging level
logging_level = "Information"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be back to Information before merging

@@ -568,6 +568,24 @@ variable "fluent_bit" {
default = {}
}

variable "fluent_bit_windows" {
description = "Fluent bit configuration windows"
type = object({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the whole object be optional ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants