feat: add Bench session workflow on localhost #1328
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ttlSecondsAfterFinished: 0 | ||
| template: | ||
| spec: | ||
| containers: |
Check warning
Code scanning / SonarCloud
Service account permissions should be restricted Medium
| template: | ||
| spec: | ||
| containers: | ||
| - name: bench-session |
Check warning
Code scanning / SonarCloud
Storage limits should be enforced Medium
| template: | ||
| spec: | ||
| containers: | ||
| - name: bench-session |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium
| ttlSecondsAfterFinished: 0 | ||
| template: | ||
| spec: | ||
| containers: |
Check warning
Code scanning / SonarCloud
Service account permissions should be restricted Medium
| template: | ||
| spec: | ||
| containers: | ||
| - name: htcmock-session |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium
| template: | ||
| spec: | ||
| containers: | ||
| - name: htcmock-session |
Check warning
Code scanning / SonarCloud
Storage limits should be enforced Medium
|
|
||
| - name: Define runner env variables | ||
| run: | | ||
| echo "core-version=$(cat versions.tfvars.json | jq '.armonik_versions.core' | sed -r 's/"//g')" >> $GITHUB_ENV |
There was a problem hiding this comment.
| echo "core-version=$(cat versions.tfvars.json | jq '.armonik_versions.core' | sed -r 's/"//g')" >> $GITHUB_ENV | |
| echo "core-version=$(cat versions.tfvars.json | jq -r '.armonik_versions.core')" >> $GITHUB_ENV |
| - id: get-armonik-endpoint | ||
| name: "Get ArmoniK's control plane endpoint" | ||
| run: | | ||
| endpoint=$(cat infrastructure/quick-deploy/localhost/generated/armonik-output.json | jq '.armonik.control_plane_url' | sed -r 's/("http:\/\/)([^:]*)(:.*)/\2/') |
There was a problem hiding this comment.
| endpoint=$(cat infrastructure/quick-deploy/localhost/generated/armonik-output.json | jq '.armonik.control_plane_url' | sed -r 's/("http:\/\/)([^:]*)(:.*)/\2/') | |
| endpoint=$(cat infrastructure/quick-deploy/localhost/generated/armonik-output.json | jq -r '.armonik.control_plane_url' | sed -r 's/(http:\/\/)([^:]*)(:.*)/\2/') |
| subtasks-levels: | ||
| description: "Levels of subtasking" | ||
| default: "1" | ||
| required: false |
There was a problem hiding this comment.
This is not used for bench
| inputs: | ||
| ntasks: | ||
| description: "Number of tasks to be created" | ||
| default: "100" |
There was a problem hiding this comment.
I think the default should be more like 100k or 1M
There was a problem hiding this comment.
Eventhough it is on localhost ?
| echo "ntasks=${{ inputs.ntasks || 500 }}" >> $GITHUB_ENV | ||
| echo "purge-data=${{ inputs.purge-data || false }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
I am not sure || works, but even if it does, you should take the default value defined in the parameter itself.
There was a problem hiding this comment.
Workflows do not consider inputs if they're triggered by an event other than workflow_dispatch or worfklow_call
| - name: Get current date | ||
| run: | | ||
| echo "date=$(printf '%(%Y-%m-%d-%Hh%Mm%Ss)T')" >> $GITHUB_ENV |
There was a problem hiding this comment.
If you really want to have this, it should be at the start of the action
There was a problem hiding this comment.
I would prefer to have a single action with a matrix that does all the benchmarks
tschneider-aneo
changed the title
|
Motivation
Related to ArmoniK benchmarking automation project, Bench application is the most suited one for testing the ArmoniK's sheer orchestration performance
Description
Use Bench action from Armonik.Action.Deploy to be able to benchmark ArmoniK with Bench application on each commit on, on localhost .
Testing
This workflow is run on every push on the PR's branch.
Impact
This PR implements a milestone for ArmoniK benchmarking capacity. A benchmark on AWS seems close when this PR is completed
Additional Information
Needs this PR to be merged before being merge
Checklist