Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create a documentation for gcp deployment and write addition informations about aws #1334

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mkgharbi-aneo
Copy link

@mkgharbi-aneo mkgharbi-aneo commented Nov 26, 2024

Motivation

Documentation of GCP not yet covered.

Description

Create the documentation for GCP deployment and adding more informations about the deployment with AWS.

Testing

[When applicable, detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]

Impact

Documentation span

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@mkgharbi-aneo mkgharbi-aneo added the Documentation Improvements or additions to documentation label Nov 26, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

@Nico-dl05 Nico-dl05 force-pushed the mkg/gcloud-doc branch 2 times, most recently from a465e72 to 25541df Compare December 6, 2024 09:45
@mkgharbi-aneo mkgharbi-aneo changed the title docs: Create a documentation for GCP deployment and write addition informations about AWS docs: create a documentation for gcp deployment and write addition informations about aws Dec 6, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to had short information about the difference between the make destroy and the bootstrap destroy; specially the fact that the last one is not meant to be perform everytime

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an explanation. Is it clear and enough ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a name change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name change to order pages based on the number and not alphabetically.
We aimed to organize the pages with the number.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a name change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a name change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarqubecloud bot commented Dec 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants