Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: location variable added in kms variable gcp #1341

Closed
wants to merge 4 commits into from

Conversation

mkgharbi-aneo
Copy link
Contributor

Motivation

Add a location kms variable of deployment in GCP

Description

KMS location added to include instead of region general

Testing

[When applicable, detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]

Impact

Location and keyring values should be modified in parameters.tfvars depending on the deployment

Additional Information

[Any additional information that reviewers should be aware of.]

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@mkgharbi-aneo mkgharbi-aneo changed the title GCP : Location variable added in KMS variable feat : location variable added in KMS variable GCP Dec 12, 2024
@mkgharbi-aneo mkgharbi-aneo changed the title feat : location variable added in KMS variable GCP feat : location variable added in kms variable gcp Dec 12, 2024
@mkgharbi-aneo mkgharbi-aneo changed the title feat : location variable added in kms variable gcp refactor : location variable added in kms variable gcp Dec 12, 2024
@mkgharbi-aneo mkgharbi-aneo changed the title refactor : location variable added in kms variable gcp refactor: location variable added in kms variable gcp Dec 12, 2024
@mkgharbi-aneo mkgharbi-aneo deleted the mkg/kms-location-gcp branch December 13, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants