Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed clone depth of get-modules to 1 #1342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AncientPatata
Copy link
Contributor

@AncientPatata AncientPatata commented Dec 11, 2024

Motivation

Running make deploy sometimes fails at the get-modules stage because of internet speed, and takes a long time to run.

Description

Instead of fetching the entire ArmoniK.Infra repository (which can take a long time), we fetch only the latest commit of the version we're trying to use.

Testing

Deployed ArmoniK with it on localhost, but it should be the same for aws/gcp.

Impact

Slightly faster deployment on slower internets.

Additional Information

None.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants