Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SQS support to ArmoniK #1344

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Added SQS support to ArmoniK #1344

wants to merge 1 commit into from

Conversation

AncientPatata
Copy link
Contributor

Motivation

SQS was added to ArmoniK.Core but was never supported in ArmoniK.Infra, now that SQS is added as a module to ArmoniK.Infra. This PR makes adjustments to ArmoniK to support these upcoming changes;

Description

Created instances of the SQS module/service account and made it toggleable through a variable. Since integrating SQS required creating a service account that will be used by ArmoniK's control and compute planes.

Testing

Initial testing through deployments, TODO.

Impact

TODO.

Additional Information

Not Applicable.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant