Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in array declaration #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rulliam
Copy link
Contributor

@Rulliam Rulliam commented Jun 24, 2022

Fix this error (fedora 36)

dex_instruction.c:655:43: error: argument 2 of type ‘u4[kMaxVarArgRegs]’ {aka ‘unsigned int[kMaxVarArgRegs]’} declared as a variable length array [-Werror=vla-parameter]
  655 | void dexInstr_getVarArgs(u2 *code_ptr, u4 arg[kMaxVarArgRegs]) {
      |                                        ~~~^~~~~~~~~~~~~~~~~~~
In file included from dex_instruction.c:23:
dex_instruction.h:278:32: note: previously declared as an ordinary array ‘u4[]’ {aka ‘unsigned int[]’}
  278 | void dexInstr_getVarArgs(u2 *, u4 []);
      |                                ^~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:56: dex_instruction.o] Error 1

https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wvla-parameter

Thank you

@Luciogi
Copy link

Luciogi commented Jun 29, 2022

thank you

@TheDauntless TheDauntless mentioned this pull request May 13, 2024
@dingshaohua-com
Copy link

Administrator@computer /cygdrive/d/code/vdexExtractor/bin
$ ./vdexExtractor -i ./boot-ext.vdex -o /
[INFO] Processing 1 file(s) from ./boot-ext.vdex
[INFO] 1 out of 1 Vdex files have been processed
[INFO] 0 Dex files have been extracted in total
[INFO] Extracted Dex files are available in '/'

why 0 file output

@RJMultiDev
Copy link

@Rulliam check your commit,why it can't output anything when i using it?

@Athwale
Copy link

Athwale commented Dec 7, 2024

It does work for me with the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants