Linux build fixes #112

bobsayshilol · 2022-08-16T16:59:03Z

This doesn't get us all the way there, but the remaining parts are either hacks or require additional functionality from delta-studio.

Note that 908103b4a10c7a874d21418ecf5aa0844602a876 depends on a similar change in https://github.com/ange-yaghi/delta-studio so merging this would fail as-is unless that's been merged.

This hasn't been tested on Windows but it should Just Work.

This addresses #2.

Blocked on ange-yaghi/delta-studio#34.

alexmyczko · 2022-08-20T16:06:42Z

Thank you for working on this! I've given it a try with:

git clone --recursive https://github.com/bobsayshilol/engine-sim.git

but I get something like:

/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_math.h:266:5: error:‘__forceinline’ does not name a type
  266 |     __forceinline ysVector Magnitude(const ysVector &v) {
      |     ^~~~~~~~~~~~~
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_math.h:272:5: error:‘__forceinline’ does not name a type
  272 |     __forceinline ysVector Normalize(const ysVector &v) {
      |     ^~~~~~~~~~~~~
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_math.h:276:5: error:‘__forceinline’ does not name a type
  276 |     __forceinline ysVector Negate(const ysVector &v) {
      |     ^~~~~~~~~~~~~
In file included from /var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/yds_animation_action.cpp:3:
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_animation_target.h: In member function ‘void TransformTarget::ClearLocation(const ysVector&)’:
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_animation_target.h:33:27: error: ‘GetX’ is not a member of ‘ysMath’
   33 |         Data[0] = ysMath::GetX(t);
      |                           ^~~~
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_animation_target.h:34:27: error: ‘GetY’ is not a member of ‘ysMath’
   34 |         Data[1] = ysMath::GetY(t);
      |                           ^~~~
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_animation_target.h:35:27: error: ‘GetZ’ is not a member of ‘ysMath’
   35 |         Data[2] = ysMath::GetZ(t);
      |                           ^~~~
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_animation_target.h: In member function ‘void TransformTarget::AccumulateQuaternion(ysQuaternion&, float)’:
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_animation_target.h:64:38: error: ‘GetScalar’ is not a member of ‘ysMath’
   64 |             float cosTheta = ysMath::GetScalar(ysMath::Dot(current, q));
      |                                      ^~~~~~~~~
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_animation_target.h:64:56: error: ‘Dot’ is not a member of ‘ysMath’; did you mean ‘Dot3’?
   64 |             float cosTheta = ysMath::GetScalar(ysMath::Dot(current, q));
      |                                                        ^~~
      |                                                        Dot3
/var/www/debian/engine-sim/git2/engine-sim/dependencies/submodules/delta-studio/src/../include/yds_animation_target.h:68:39: error: ‘Negate’ is not a member of ‘ysMath’; did you mean ‘Negate3’?
   68 |                 transformed = ysMath::Negate(q);
      |                                       ^~~~~~
      |                                       Negate3
gmake[2]: *** [dependencies/submodules/delta-studio/CMakeFiles/delta-core.dir/build.make:76: dependencies/submodules/delta-studio/CMakeFiles/delta-core.dir/src/yds_animation_action.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:581: dependencies/submodules/delta-studio/CMakeFiles/delta-core.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2

bobsayshilol · 2022-08-20T16:12:54Z

Yeah, that's why it's still in draft. It requires changes to https://github.com/ange-yaghi/delta-studio too which is where you're seeing all of the errors. Check the discord for the current progress.

alexmyczko · 2022-08-20T16:14:12Z

I read about that "discord", but no clue what it is? URL? ah https://discord.gg/chKreEmXw6 thanks for the explanation

discord has never worked for me, can't join, invalid invite code, my account is not working, whatever. is there a matrix room, or irc channel for this?

bobsayshilol · 2022-08-21T14:34:28Z

discord has never worked for me, can't join, invalid invite code, my account is not working, whatever. is there a matrix room, or irc channel for this?

I don't believe so. If it's not mentioned in the repo README or the youtube video then it's probably not a thing.

MacSlash · 2022-09-05T17:16:17Z

I'm trying to ask about adding an IRC / Matrix channel rn, I'll link the Matrix if it gets added

MacSlash · 2022-09-06T10:52:31Z

Okay well I was given permission to create my own Matrix channel to discuss it, at address #unofficial-engine-sim:matrix.org

TheFGFSEagle · 2022-09-06T23:42:20Z

So does this compile on Linux in way yet ? Seen your demo video on YouTube … you made an incredible program, really. Great work, and don't ever let yourself discourage by some "would-like-to-be"-expert-reddit users ! ;)

constexpr is for values known at compile time so there's no reason for these to be extern since they can't be defined externally.

These work on all platforms rather than \ which only works on Windows.

I'm not 100% sure why GCC wants this but it has something to do with aggregate initialisation (= {}) and default values for members.

This is never called and GCC warns that the Type template on the method conflicts with the Type template on the class.

GCC picks up the static_assert(false) even if the template isn't instantiated, and =delete-ing the method has the same effect of notifying the caller if it's not specialised later in this header. Also remove extraneous extern that GCC doesn't like.

These are presumably pulled in by other stdlib headers on Windows.

start() is a function so this check was wrong, however it looks like this method is never called so it's probably not been an issue.

powf() is a C function but std::pow() is the thin C++ wrapper that delegates to pow(), powf(), or powl() dependent on argument type. Most of these are already acting on floats, and those that aren't have been fixed up to do so.

Compiler smart. Usually.

This currently links to a prebuilt Windows library which we can't use on Linux.

Also add missing include.

This is an odd fix, but it works and means that symbols in engine-sim don't disappear.

This allows the code to build since it brings in fixes that those submodules need merging.

bobsayshilol · 2022-10-15T11:26:52Z

Replaced by #346 which is more feature complete.

alexmyczko mentioned this pull request Aug 17, 2022

Building on !Windows (eg. FreeBSD/Linux) #118

Closed

bobsayshilol force-pushed the gcc-fixes branch from cb55f72 to 4544d7c Compare August 21, 2022 14:10

R3dst0ne mentioned this pull request Sep 1, 2022

Fix compilation issues. #220

Closed

bobsayshilol force-pushed the gcc-fixes branch from 4544d7c to 79dbbb1 Compare September 3, 2022 13:42

bobsayshilol force-pushed the gcc-fixes branch from 79dbbb1 to 7880d5f Compare September 6, 2022 20:03

bobsayshilol force-pushed the gcc-fixes branch 3 times, most recently from e3073af to 36f4e97 Compare September 11, 2022 16:47

ange-yaghi and others added 15 commits September 30, 2022 07:56

Fixed minor bug with dyno torque algorithm

0e44057

Replace extern with static

210b4f5

constexpr is for values known at compile time so there's no reason for these to be extern since they can't be defined externally.

Use / for path separators

0833790

These work on all platforms rather than \ which only works on Windows.

Add a user defined constructor for Mix

995d312

I'm not 100% sure why GCC wants this but it has something to do with aggregate initialisation (= {}) and default values for members.

Remove unused method

38439f4

This is never called and GCC warns that the Type template on the method conflicts with the Type template on the class.

Add missing stdlib headers

31ca92b

These are presumably pulled in by other stdlib headers on Windows.

Use the correct member in ring_buffer.h

d6e3427

start() is a function so this check was wrong, however it looks like this method is never called so it's probably not been an issue.

Remove unnecessary f's from stdlib cmath functions

3e67ced

powf() is a C function but std::pow() is the thin C++ wrapper that delegates to pow(), powf(), or powl() dependent on argument type. Most of these are already acting on floats, and those that aren't have been fixed up to do so.

GCC fixes

54422c1

Move divisions that could be 1/0 to where that can't happen

9df4a29

Add missing overrides that clang wants

7ebbe5f

Add a main() and common app running code

61db309

Replace forceinline with inline for now

f4491fa

Compiler smart. Usually.

Only enable discord on Win32

88d9741

This currently links to a prebuilt Windows library which we can't use on Linux.

bobsayshilol added 5 commits September 30, 2022 17:22

More renaming for GCC

febae6c

Also add missing include.

Use the x-platform WAV reader

af104db

Fix linker issue by linking engine-sim last

c83064c

This is an odd fix, but it works and means that symbols in engine-sim don't disappear.

Default to Release when using single-configuration generators

9f41bcc

More GCC compilation fixes

6c4a327

bobsayshilol force-pushed the gcc-fixes branch from 36f4e97 to a2885f5 Compare September 30, 2022 16:46

ange-yaghi force-pushed the master branch from 0e44057 to 80a9075 Compare September 30, 2022 19:38

Temporary update of submodules

4629870

This allows the code to build since it brings in fixes that those submodules need merging.

bobsayshilol force-pushed the gcc-fixes branch from a2885f5 to 4629870 Compare October 2, 2022 14:13

bobsayshilol mentioned this pull request Oct 15, 2022

SDL build #346

Draft

bobsayshilol closed this Oct 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux build fixes #112

Linux build fixes #112

bobsayshilol commented Aug 16, 2022 •

edited

Loading

alexmyczko commented Aug 20, 2022

bobsayshilol commented Aug 20, 2022

alexmyczko commented Aug 20, 2022 •

edited

Loading

bobsayshilol commented Aug 21, 2022

MacSlash commented Sep 5, 2022

MacSlash commented Sep 6, 2022 •

edited

Loading

TheFGFSEagle commented Sep 6, 2022 •

edited

Loading

bobsayshilol commented Oct 15, 2022

Linux build fixes #112

Linux build fixes #112

Conversation

bobsayshilol commented Aug 16, 2022 • edited Loading

alexmyczko commented Aug 20, 2022

bobsayshilol commented Aug 20, 2022

alexmyczko commented Aug 20, 2022 • edited Loading

bobsayshilol commented Aug 21, 2022

MacSlash commented Sep 5, 2022

MacSlash commented Sep 6, 2022 • edited Loading

TheFGFSEagle commented Sep 6, 2022 • edited Loading

bobsayshilol commented Oct 15, 2022

bobsayshilol commented Aug 16, 2022 •

edited

Loading

alexmyczko commented Aug 20, 2022 •

edited

Loading

MacSlash commented Sep 6, 2022 •

edited

Loading

TheFGFSEagle commented Sep 6, 2022 •

edited

Loading