Allow setting K8S_DNS instead of getting it from default resov.conf #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add settings option to set the local dns server instead of using the default one provided by resolv.conf
Benefits
Allowing to set the dns to be used, but only for resolved domains via pod-gateway dnsmasq.
Possible drawbacks
As its a static setting, changes to dns settings wont affect pod-gateway directly. Something to keep in mind.
Applicable issues
I had an issue where the K8s-nameserver from resolv.conf was 1.1.1.1 (i think based on the worker node) and neither dnsConfig.nameservers nor dnsPolicy could change it.
I made this commit to make the change regardless.