Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update peerDependencies requirements to support TS 3 #77

Open
artola opened this issue Aug 7, 2018 · 4 comments
Open

Update peerDependencies requirements to support TS 3 #77

artola opened this issue Aug 7, 2018 · 4 comments

Comments

@artola
Copy link
Contributor

artola commented Aug 7, 2018

The package requires "typescript": ">= 2.3.1 < 3", then this warning is printed when running together to TS 3.

npm WARN [email protected] requires a peer of typescript@>= 2.3.1 < 3 but none is installed. You must install peer dependencies yourself.

Would be nice to update the peerDependencies to support TS 3, I did not find any problem while using it, but might be recommended check it with the tests.
@angelozerr
Copy link
Owner

Any PR are welcome!

@artola
Copy link
Contributor Author

artola commented Aug 7, 2018

PR is not passing CI.
I do not understand why when the change is just "peerDependencies" and should impact only in the user's environment.
Any hint?

@juansalvatella
Copy link

Has anyone been able to check this out?

@artola
Copy link
Contributor Author

artola commented Oct 25, 2019

Has anyone been able to check this out?

Might be that you are interested to replace this plugin with the newest: typescript-tslint-plugin.

@michaelsauter michaelsauter mentioned this issue Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@angelozerr @juansalvatella @artola