Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump typescript version #440

Merged

Conversation

michaelsauter
Copy link
Member

@michaelsauter michaelsauter commented Aug 6, 2020

Fixes #439.

Output now:

INFO: Sensor TypeScript analysis [javascript] (done) | time=7537ms
INFO: Sensor JavaXmlSensor [java]
INFO: Sensor JavaXmlSensor [java] (done) | time=1ms
INFO: Sensor SonarTS [typescript]
INFO: Since SonarTS v2.0, TypeScript analysis is performed by SonarJS analyzer v6.0 or later. No TypeScript analysis is performed by SonarTS.
INFO: Sensor SonarTS [typescript] (done) | time=0ms

Build is still green, test run seems fine.

However, there is a warning:

npm WARN [email protected] requires a peer of typescript@>= 2.3.1 < 3 but none is installed. You must install peer dependencies yourself.

See also angelozerr/tslint-language-service#77.

I would still merge this as run is fine, whereas previously we had an exception in the log output, even though the build finished successfully as well.

@michaelsauter michaelsauter added the bug Something isn't working label Aug 6, 2020
@michaelsauter michaelsauter self-assigned this Aug 6, 2020
@michaelsauter michaelsauter merged commit b831ab7 into opendevstack:master Aug 6, 2020
@michaelsauter michaelsauter deleted the task/bump-ts-version branch August 6, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E cypress scanning has issues
2 participants