Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cypress quickstarter dependencies #446

Merged
merged 3 commits into from
Aug 21, 2020

Conversation

herrkoch
Copy link
Contributor

(including major version update to Cypress 5)

Fixes #441

Tasks:

  • Updated documentation in docs/modules/... directory
  • Adjusted and verified tests in tests/... directory -> Tests ran fine in Jenkins of my OpenShift playground project

@herrkoch herrkoch requested a review from michaelsauter August 20, 2020 11:15
@herrkoch
Copy link
Contributor Author

I just saw that there are a couple of warnings in the Jenkins build that I did not see locally (even though I removed node_modules completely). I'll try to reproduce and fix the warnings.

@herrkoch
Copy link
Contributor Author

Ok one of the warnings about tslint-language-service you also mentioned in #440 @michaelsauter . It seems the plugin is deprecated in favor of https://github.com/microsoft/typescript-tslint-plugin . I'll try to replace it.

@herrkoch
Copy link
Contributor Author

The other warning is about rxjs-tslint, which seems to provide obsolete tslint rules after the update to RxJS v6, so I am going to remove it.

…ugin; removed rxjs tslint plugin with obsolete rules for rxjs v6
@herrkoch
Copy link
Contributor Author

The third and last deprecation warning is about har-validator which is a transitive dependency of Cypress, so unfortunately I can't do anything about it right now and hope the Cypress devs replace it soon. The PR is now ready for review.

@herrkoch
Copy link
Contributor Author

One last remark to this warning: tput: No value for $TERM and no -T specified-> That seems to come from the terminal configuration Jenkins uses, so not related to the Cypress quickstarter. I can't observe this locally.

@michaelsauter
Copy link
Member

@herrkoch Awesome, looks good to me 👍

Maybe @cschweikert or someone else approve to have some "frontend eyes" on this?

@netzartist netzartist self-requested a review August 21, 2020 06:50
@netzartist
Copy link

Looks fine for me.

@michaelsauter michaelsauter merged commit 2bafc8d into master Aug 21, 2020
@michaelsauter michaelsauter deleted the fix/cypress-#441-update-dependencies branch August 21, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various warnings in E2E Cypress build
3 participants