Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert Navigation component to Analog SFC #287

Merged
merged 2 commits into from
May 31, 2024

Conversation

nartc
Copy link
Contributor

@nartc nartc commented May 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: part of #247

What is the new behavior?

Navigation and App are now Analog SFC

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

netlify bot commented May 30, 2024

Deploy Preview for angular-hub ready!

Name Link
🔨 Latest commit 2f111a2
🔍 Latest deploy log https://app.netlify.com/sites/angular-hub/deploys/6658e78e3650b10008fbe9a3
😎 Deploy Preview https://deploy-preview-287--angular-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nartc nartc force-pushed the navigation-analog branch from 2963440 to 349b457 Compare May 30, 2024 19:53
@geromegrignon geromegrignon merged commit 3ce001e into angular-sanctuary:main May 31, 2024
4 checks passed
@geromegrignon
Copy link
Contributor

Thanks @nartc! I was about to create an issue for the community to contribute as there was a refactoring opportunity for people willing to contribute. Awesome to get it with analog authoring format!

@geromegrignon
Copy link
Contributor

I'm going to investigate, serving the app locally works as expected but there are some regressions on production (forms missing and burger menu not visible on small screens):

image

@geromegrignon
Copy link
Contributor

Broken content is all about PrimeNG components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants