-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add japanese comunities and podcasts #317
Conversation
✅ Deploy Preview for angular-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @ver-1000000, thanks for your contribution. Are the following communities still active? Based on the website provided, there were no events for years.
|
Thanks, @geromegrignon. I apparently did not understand the policy of this repository. I will immediately review the PR as suggested and repush. |
- removed inactive Japanese communities - changes better url for ng-jp
Hi thanks for the change, I'll update the CONTRIBUTING guide for a more explicite description. I'll see in another PR how to handle StartupAngular and ng-japan to evolve the current schema so Communities podcasting their content are listing under Podcasts, rather than being 2 different entries. |
@all-contributors please add @ver-1000000 for code |
I've put up a pull request to add @ver-1000000! 🎉 |
Hi @ver-1000000, I'll open addition of all communities soon (to add the ones removed from your first commit).
If listing an inactive community might not be useful to find a local event, it might still be a way to know if there is some possible revival as a community member wanting to be involved. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Add japan informations.
Does this PR introduce a breaking change?
Other information