Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add japanese comunities and podcasts #317

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

ver-1000000
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Add japan informations.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for angular-hub ready!

Name Link
🔨 Latest commit f2cdda6
🔍 Latest deploy log https://app.netlify.com/sites/angular-hub/deploys/667e7a53f7c5030008e7dca0
😎 Deploy Preview https://deploy-preview-317--angular-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@geromegrignon
Copy link
Contributor

Hi @ver-1000000, thanks for your contribution.

Are the following communities still active? Based on the website provided, there were no events for years.
As the goal is to provide a way for the community to meet people, I want to avoid listing no longer active communities.

@ver-1000000
Copy link
Contributor Author

Thanks, @geromegrignon.

I apparently did not understand the policy of this repository.

I will immediately review the PR as suggested and repush.

ver-1000000 and others added 2 commits July 1, 2024 03:55
- removed inactive Japanese communities
- changes better url for ng-jp
@geromegrignon
Copy link
Contributor

Hi thanks for the change, I'll update the CONTRIBUTING guide for a more explicite description.

I'll see in another PR how to handle StartupAngular and ng-japan to evolve the current schema so Communities podcasting their content are listing under Podcasts, rather than being 2 different entries.

@geromegrignon geromegrignon merged commit 08be7af into angular-sanctuary:main Jul 2, 2024
1 check passed
@geromegrignon
Copy link
Contributor

@all-contributors please add @ver-1000000 for code

Copy link
Contributor

@geromegrignon

I've put up a pull request to add @ver-1000000! 🎉

@geromegrignon
Copy link
Contributor

Hi @ver-1000000, I'll open addition of all communities soon (to add the ones removed from your first commit).
I'll update the project as a prerequisite:

  • add the last past events for communities without any event listed
  • add a filter to list by default only the communities with upcoming events or with the last past event being under some threshold (like 1-2 years).

If listing an inactive community might not be useful to find a local event, it might still be a way to know if there is some possible revival as a community member wanting to be involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants