Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Setup receivedData + requestCount metrics (requires benchpress 2.0.0-alpha.53) #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ochafik
Copy link

@ochafik ochafik commented Dec 10, 2015

  • added instructions on how to use a local benchpress repo

(please note that this requires benchpress 2.0.0-alpha.53, not published yet)

See
angular/angular@fe1dd77
5cdf5a0b16

@@ -35,6 +35,9 @@ describe('deep tree baseline', function() {
$('#createDom').click();
},
bindings: [
// TODO(ochafik): Uncomment these metrics after 2.0.0-alpha.53:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove these comments and add a comment to the PR that it requires alpha.53?

@ochafik ochafik force-pushed the bind-request-metrics branch from 420a6a3 to 5da43a7 Compare December 10, 2015 22:14
@ochafik ochafik changed the title Include (commented out) upcoming receivedData + requestCount metrics… Setup receivedData + requestCount metrics (requires benchpress 2.0.0-alpha.53) Dec 10, 2015
@ochafik ochafik force-pushed the bind-request-metrics branch from 5da43a7 to 14c230c Compare December 10, 2015 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants