fix(material/form-field): move error aria-live to parent container #30155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
requested review from
crisbeto and
mmalerba
and removed request for
a team
andrewseguin
added
the
target: patch
andrewseguin
added
the
dev-app preview
crisbeto
approved these changes
Dec 9, 2024
|
Deployed dev-app for f57542a to: https://ng-dev-previews-comp--pr-angular-components-30155-dev-9jziu7lw.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
andrewseguin
force-pushed
the
form-field-error
branch
2 times, most recently
from
8b038a3 to
b09e2c6
Compare
andrewseguin
force-pushed
the
form-field-error
branch
from
b09e2c6 to
f57542a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight change in behavior where the aria-live is always set to polite even if the user puts a different
aria-livevalue on the error. Based on internal usage, this is very rare (and not part of the documented API)Fixes #29616