perf(cdk/table): Use afterNextRender for sticky styling. Fixes a perf… #30242
+161
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
area: performance
kseamon
force-pushed
the
table-afterNextRender
branch
from
c7ca3b7 to
5957299
Compare
…ormance regression dating back to angular#28393 and removes need for coalesced sticky styler.
kseamon
force-pushed
the
table-afterNextRender
branch
from
1c0c337 to
08b78b4
Compare
kseamon
requested review from
crisbeto and
mmalerba
and removed request for
a team
mmalerba
approved these changes
Dec 27, 2024
mmalerba
reviewed
Dec 27, 2024
| @@ -64,6 +67,7 @@ export class StickyStyler { | |||
| private _isBrowser = true, | |||
| private readonly _needsPositionStickyOnElement = true, | |||
| private readonly _positionListener?: StickyPositioningListener, | |||
| private readonly _tableInjector?: Injector, | |||
There was a problem hiding this comment.
can you just get ahold of this with inject() instead? then it wouldn't have to be optional and we could get rid of the logic branch for if it isn't provided
There was a problem hiding this comment.
I don't think this class is constructed in an injection context though? The table constructs this during ngOnInit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ormance regression dating back to #28393 and removes need for coalesced sticky styler.