feat(aria/combobox): adds disabled combobox example to dev-app #32152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
adolgachev and
tjshiu
and removed request for
a team
essjay05
added
the
dev-app preview
|
Deployed dev-app for 116fd72 to: https://ng-dev-previews-comp--pr-angular-components-32152-dev-431sk70x.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
tjshiu
reviewed
Oct 23, 2025
Comment on lines
+151
to
+160
| [ngCombobox][aria-disabled='true'] { | ||
| opacity: 0.5; | ||
| pointer-events: none; | ||
| cursor: default; | ||
| } | ||
|
|
||
| [ngCombobox][aria-disabled='true'] input.example-combobox-input { | ||
| color: var(--mat-sys-on-surface-variant); | ||
| background-color: var(--mat-sys-surface); | ||
| } |
There was a problem hiding this comment.
Where are these colors coming from? Should they match these ones? https://m3.material.io/components/text-fields/specs
Adds disabled binding to aria combobox.ts to have disabled attribute be automatically added as aria-disabled on the parent div and disabled on the input of combobox.
Updates dev-app to add disabled combobox using the proposed disabled bindings to aria/combobox.ts.
Updates .css file to fix lint errors.
essjay05
force-pushed
the
aria-disabled-combobox-w-disabled-bindings
branch
from
021f68a to
116fd72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dev-app to include disabled combobox example using the proposed
disabled bindings to aria/combobox.ts.
Screencast
of demo is here.