Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

feature(annotations): add ES7 decorator functions #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

L8D
Copy link

@L8D L8D commented May 18, 2015

Review on Reviewable

@ghost
Copy link

ghost commented Jul 11, 2015

I think the decorators should also be exported from the index.js. Otherwise it works great. Thanks.

@Pajn
Copy link

Pajn commented Aug 20, 2015

Any update on this? Would need this.

I had to change line 33 in util.js from
var ownKeys = (this.Reflect to var ownKeys = (Reflect for it to work, but that seems to be an older thing.

@L8D
Copy link
Author

L8D commented Sep 8, 2015

This is now broken as the proposal has changed slightly. The new signature is (target, name, descriptor) so we'd need to annotate descriptor.value if a decorator is applied to a factory function instead of a class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants