main - af29a92 perf(material/tooltip): Tiny but measurable optimizati…

…on to MatTooltip construction. Defer hooking up to directionality changes until overlay is created. (#30214)
angular · Dec 20, 2024 · 8b8e8e6 · 8b8e8e6
1 parent 5c81604
commit 8b8e8e6
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/fesm2022/tooltip.mjs b/fesm2022/tooltip.mjs
@@ -104,6 +104,7 @@ class MatTooltip {
     _currentPosition;
     _cssClassPrefix = 'mat-mdc';
     _ariaDescriptionPending;
+    _dirSubscribed = false;
     /** Allows the user to define the position of the tooltip relative to the parent element */
     get position() {
         return this._position;
@@ -238,11 +239,6 @@ class MatTooltip {
                 this.tooltipClass = defaultOptions.tooltipClass;
             }
         }
-        this._dir.change.pipe(takeUntil(this._destroyed)).subscribe(() => {
-            if (this._overlayRef) {
-                this._updatePosition(this._overlayRef);
-            }
-        });
         this._viewportMargin = MIN_VIEWPORT_TOOLTIP_THRESHOLD;
     }
     ngAfterViewInit() {
@@ -384,6 +380,14 @@ class MatTooltip {
         if (this._defaultOptions?.disableTooltipInteractivity) {
             this._overlayRef.addPanelClass(`${this._cssClassPrefix}-tooltip-panel-non-interactive`);
         }
+        if (!this._dirSubscribed) {
+            this._dirSubscribed = true;
+            this._dir.change.pipe(takeUntil(this._destroyed)).subscribe(() => {
+                if (this._overlayRef) {
+                    this._updatePosition(this._overlayRef);
+                }
+            });
+        }
         return this._overlayRef;
     }
     /** Detaches the currently-attached tooltip. */

diff --git a/fesm2022/tooltip.mjs.map b/fesm2022/tooltip.mjs.map
diff --git a/tooltip/index.d.ts b/tooltip/index.d.ts
@@ -96,6 +96,7 @@ export declare class MatTooltip implements OnDestroy, AfterViewInit {
     private _currentPosition;
     private readonly _cssClassPrefix;
     private _ariaDescriptionPending;
+    private _dirSubscribed;
     /** Allows the user to define the position of the tooltip relative to the parent element */
     get position(): TooltipPosition;
     set position(value: TooltipPosition);