FIX: Migrate legacy hamburger menu links to sidebar #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OsamaSayegh
force-pushed
the
fix/move-links-from-legacy-hamburger-to-sidebar
branch
from
0f8f2dd to
ae1fcd8
Compare
|
@OsamaSayegh Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy hamburger menu, which is implemented using the hamburger-menu widget, is being removed from core (see discourse/discourse#24788 and discourse/discourse@832b3b9), so we need to migrate all customizations that currently target the legacy hamburger menu to the new sidebar.
This PR migrates the calendar and agenda links that the plugin adds to the legacy hamburger menu to the new sidebar. The
legacyoption is still available for sites running the stable branch, so the logic for the legacy hamburger menu should be kept around until Discourse 3.2.0 is released at which the code for the legacy menu can be safely deleted.