FEATURE: add Optional countdown for e.g. deadlines

[merefield]

Adds an optional "deadline" option to event setup:

That presents a countdown on the Topic List (and Topic):

• Also converts Event Form Component to gjs
• Adds some tests

[angusmcleod]

@merefield Generally looks ok, however I'm still not convinced there isn't something in Discourse we could be using for the countdown display itself. See my comments.

[angusmcleod]

@merefield The issue was that you had added deadline as an attribute to the basic event serializer, however it was no longer an attribute on the model.

10246da

[angusmcleod]

@merefield I took the opportunity to review the UI, and I think it still needs a bit more tweaking, in addition to anything arising out of my question concerning the use of core components.

• It's a little cramped in the display in the composer, particularly if there's a timezone, i.e. the deadline icon is just a bit too close.
• It there's 0 hours the hours should not be displayed at all.

[merefield]

@merefield The issue was that you had added deadline as an attribute to the basic event serializer, however it was no longer an attribute on the model.

10246da

@angusmcleod it's still completely broken

You cannot amend an event without a 500 error.

resolved through recreation of DB

[angusmcleod]

@merefield I'm seeing a new exception when changing the timezone when editing an event. See this video:

https://www.loom.com/share/a2b9987eccf249b59b2603cd053ebbec?sid=714ec1ef-b013-4302-88b2-5b426d048713

[merefield]

@merefield I'm seeing a new exception when changing the timezone when editing an event. See this video:

https://www.loom.com/share/a2b9987eccf249b59b2603cd053ebbec?sid=714ec1ef-b013-4302-88b2-5b426d048713

thanks Angus, I'll take a look

[merefield]

@angusmcleod that should be fixed now, apologies.

[angusmcleod]

@merefield Some minor style feedback

https://www.loom.com/share/1c3556960faf43d8b8d2d56ab632bbfc?sid=f81265cc-4839-4b7d-8b9f-b7a639a041e7

[merefield]

should be resolved

…

On Thu, Sep 19, 2024 at 9:22 AM Angus McLeod ***@***.***> wrote: @merefield <https://github.com/merefield> Some minor style feedback https://www.loom.com/share/1c3556960faf43d8b8d2d56ab632bbfc?sid=f81265cc-4839-4b7d-8b9f-b7a639a041e7 — Reply to this email directly, view it on GitHub <#149 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIPDD6EAO4MEC4EJAHZQLELZXKCTHAVCNFSM6AAAAABONALYGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRQGMYTCOBYGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[angusmcleod]

@merefield Thanks. Just doing some more checking I see that the events with deadlines in the calendar popovers need some style improvements. The addition of the deadline squishes the content too much.

Once that's addressed I'll merge this.

[merefield]

@merefield Thanks. Just doing some more checking I see that the events with deadlines in the calendar popovers need some style improvements. The addition of the deadline squishes the content too much.

Once that's addressed I'll merge this.

I'm wondering if I simply don't show them in this view? Would that be acceptable?

[angusmcleod]

@merefield Maybe just push it to the next line in this view? It may be better to have consistency across all appearances of the event label.

[merefield]

How about this?:

(ignore the dev-tools highlighting)

I've pushed that change.

[merefield]

Improved:

Just for deadlines I add consistent icon right margin.

[angusmcleod]

@merefield Thanks. Approved.

[merefield]

thanks for the review and merge @angusmcleod !