Add support for existing VNets to the dcos-one-master template. #1
Conversation
| @@ -248,7 +248,7 @@ | |||
| "type": "string" | |||
| }, | |||
| "linuxVersion": { | |||
| "defaultValue": "16.04.201605161", | |||
| "defaultValue": "latest", | |||
There was a problem hiding this comment.
We pin to a specific version because of words introduced upstream that caused an outage.
There was a problem hiding this comment.
Sorry, s/words/errors (code review on a phone is a bad idea)
There was a problem hiding this comment.
The current version (16.04.201605161) is missing so the template doesn't currently work. I think we need a better story for ensuring that the templates in github work. How do we choose/validate what image to use currently? We need some sort of automated testing here.
There was a problem hiding this comment.
Just ran into the same same issue while playing with this template. The version is actually available but under another SKU. Try replacing 16.04.0-DAILY-LTS by 16.04.0-LTS.
|
Comments addressed, please re-check. |
This splits the vnet config out into an optional component.