Update Selenium 4.18.1

anhtester · Feb 25, 2024 · 7845ba8 · 7845ba8
1 parent 925186c
commit 7845ba8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -467,7 +467,7 @@
                     <configuration>
                         <suiteXmlFiles>
                             <!--<suiteXmlFile>${suite.all}</suiteXmlFile>-->
-                            <suiteXmlFile>src/test/resources/suites/BuildApp.xml</suiteXmlFile>
+                            <suiteXmlFile>src/test/resources/suites/CMS/LoginTestCMS.xml</suiteXmlFile>
                         </suiteXmlFiles>
                         <argLine>
                             -javaagent:"${settings.localRepository}/org/aspectj/aspectjweaver/${aspectjweaver.version}/aspectjweaver-${aspectjweaver.version}.jar"

diff --git a/src/main/java/com/anhtester/driver/TargetFactory.java b/src/main/java/com/anhtester/driver/TargetFactory.java
@@ -40,14 +40,17 @@ public WebDriver createInstance(String browser) {
         Target target = Target.valueOf(FrameworkConstants.TARGET.toUpperCase());
         WebDriver webdriver;
 
+        String browserName = System.getProperty("browser") != null ? System.getProperty("browser")
+                : browser;
+
         switch (target) {
             case LOCAL:
                 //Create new driver from Enum setup in BrowserFactory class
-                webdriver = BrowserFactory.valueOf(browser.toUpperCase()).createDriver();
+                webdriver = BrowserFactory.valueOf(browserName.toUpperCase()).createDriver();
                 break;
             case REMOTE:
                 //Create new driver on Cloud (Selenium Grid, Docker) from method below
-                webdriver = createRemoteInstance(BrowserFactory.valueOf(browser.toUpperCase()).getOptions());
+                webdriver = createRemoteInstance(BrowserFactory.valueOf(browserName.toUpperCase()).getOptions());
                 break;
             default:
                 throw new TargetNotValidException(target.toString());