Skip to content

Commit

Permalink
Merge pull request #163 from animint/fix162
Browse files Browse the repository at this point in the history
fix CRAN check issues
  • Loading branch information
tdhock authored Nov 11, 2024
2 parents 9428d11 + 78265d1 commit fb053f9
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 18 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: animint2
Title: Animated Interactive Grammar of Graphics
Version: 2024.10.11
Version: 2024.11.2
URL: https://animint.github.io/animint2/
BugReports: https://github.com/animint/animint2/issues
Authors@R: c(
Expand Down
2 changes: 0 additions & 2 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@ export(scale_y_log10)
export(scale_y_reverse)
export(scale_y_sqrt)
export(should_stop)
export(start_servr)
export(stat_bin)
export(stat_bin2d)
export(stat_bin_2d)
Expand All @@ -478,7 +477,6 @@ export(stat_summary_bin)
export(stat_summary_hex)
export(stat_unique)
export(stat_ydensity)
export(stop_servr)
export(theme)
export(theme_animint)
export(theme_bw)
Expand Down
8 changes: 6 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
# Changes in version 2024.11.2 (PR#163)

- Added [gtable] to \link{gtable} to fix new CRAN issue (\link{} targets missing package anchors).

# Changes in version 2024.10.10 (PR#154)

- Updated `animist.js` to use classes for source links, resolving issue #145.
- Updated `animist.js` to use classes for source links, resolving issue #145.

# Changes in version 2024.9.18 (PR#131)

- Added functionality to capture screenshot in animint2pages
- Added functionality to capture screenshot in animint2pages

# Changes in version 2024.9.17

Expand Down
2 changes: 0 additions & 2 deletions R/guide-colorbar.r
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
#'
#' Colour bar guide shows continuous color scales mapped onto values.
#' Colour bar is available with \code{scale_fill} and \code{scale_colour}.
#' For more information, see the inspiration for this function:
#' \href{http://www.mathworks.com/help/techdoc/ref/colorbar.html}{Matlab's colorbar function}.
#'
#' Guides can be specified in each \code{scale_*} or in \code{\link{guides}}.
#' \code{guide="legend"} in \code{scale_*} is syntactic sugar for
Expand Down
4 changes: 2 additions & 2 deletions R/plot-build.r
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,15 @@ layer_grob <- function(plot, i = 1L) {
#' Build a plot with all the usual bits and pieces.
#'
#' This function builds all grobs necessary for displaying the plot, and
#' stores them in a special data structure called a \code{\link{gtable}}.
#' stores them in a special data structure called a \code{\link[gtable]{gtable}}.
#' This object is amenable to programmatic manipulation, should you want
#' to (e.g.) make the legend box 2 cm wide, or combine multiple plots into
#' a single display, preserving aspect ratios across the plots.
#'
#' @seealso \code{\link{print.gganimintplot}} and \code{link{benchplot}} for
#' for functions that contain the complete set of steps for generating
#' a ggplot2 plot.
#' @return a \code{\link{gtable}} object
#' @return a \code{\link[gtable]{gtable}} object
#' @keywords internal
#' @param data plot data generated by \code{\link{ggplot_build}}
#' @export
Expand Down
4 changes: 1 addition & 3 deletions man/animint2dir.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion man/animint2pages.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions man/ggplot_gtable.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions man/guide_colourbar.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/testthat/helper-functions.R
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ tests_run <- function(dir = ".", filter = NULL) {
#' @export
tests_exit <- function() {
Sys.unsetenv("ANIMINT_BROWSER")
res <- stop_servr(tmpPath = find_test_path())
res <- animint2:::stop_servr(tmpPath = find_test_path())
invisible(all(res))
}

Expand Down
Binary file removed tests/testthat/testthat-problems.rds
Binary file not shown.

0 comments on commit fb053f9

Please sign in to comment.