Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Birthday Machine #161

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Automatic Birthday Machine #161

wants to merge 11 commits into from

Conversation

ampurr
Copy link
Contributor

@ampurr ampurr commented Oct 29, 2024

No description provided.

@ampurr ampurr changed the title Automatic birthday machine Automatic Birthday Machine Oct 29, 2024
@ampurr
Copy link
Contributor Author

ampurr commented Oct 29, 2024

When I said it'd take a hot minute, I apparently meant about an hour or so. Nice job, past me. Thank you, pkgdown and usethis developers. You're the real heroes here. 🐈

Anyway, the website has been updated and updates itself every time something is pushed or pulled. Note to self: Update the internal website documentation.

As an aside, I think this might actually be worse for the environment than us manually re-rendering the site when needed. You win some, you lose some by contributing to climate change, I guess.

As a second more important aside, @tdhock: If you choose to merge this, you'll probably want to go to .github/workflows/pkgdown.yaml and strip branches: [main, master, automatic-birthday-machine] to branches: [master].

I know like nothing about infosec, but the fact that I could force the website to update from a branch and bypass your decision-making feels kinda concerning. Hell, I could go and write "CATS RULE, DOGS DROOL" on the website right now and it'd update without your input. But that's a separate matter.

@tdhock
Copy link
Collaborator

tdhock commented Oct 29, 2024

About infosec, as member of @animint/developers you have maintain permission on this repo.

so this PR would run pkgdown to re-make doc web site during every PR?

I think it would be better to only run that on pushes to master, which I think means removing the pull_request workflow, is that right?

@ampurr
Copy link
Contributor Author

ampurr commented Oct 30, 2024

About infosec, as member of @animint/developers you have maintain permission on this repo.

Yeah, that's true. What's new is that .github/workflows/pkgdown.yaml effectively gives us write permission on the website. In practice, not a big problem. I trust that you trust the animint developers. :>

so this PR would run pkgdown to re-make doc web site during every PR?

Yup.

I think it would be better to only run that on pushes to master, which I think means removing the pull_request workflow, is that right?

I'm pretty sure, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants