Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle pin flows #297

Merged
merged 3 commits into from
Feb 24, 2025
Merged

fix: correctly handle pin flows #297

merged 3 commits into from
Feb 24, 2025

Conversation

janrtvld
Copy link
Contributor

No description provided.

} catch (e) {
setIsProcessing(false)
if (e instanceof InvalidPinError) {
if (shouldUsePin) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doest this also handle the biometric prompt canceled / incorrect error?

There's two biometric errors. Not sure if they're handled somewhere higher/ lower. It would probably be good if we can create a proof sharing pipeline at some point, that will be used for ALL proof sharing, and you can toggle the options that are needed. As with the offline / openid /dc api / whatever it's hard to keep everything in sync

if (e instanceof BiometricAuthenticationCancelledError) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I test the biometrics flow? None of the funke flows seem to trigger it? Or do I need to be on secure enclave to test that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes secure env

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay i handled it the same way as the other flows, but unable to test because secure env is broken.

@TimoGlastra TimoGlastra merged commit 7dc5e9a into main Feb 24, 2025
1 check passed
@TimoGlastra TimoGlastra deleted the fix/use-pin-changes branch February 24, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants