-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly handle pin flows #297
Conversation
Signed-off-by: Jan <[email protected]>
} catch (e) { | ||
setIsProcessing(false) | ||
if (e instanceof InvalidPinError) { | ||
if (shouldUsePin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doest this also handle the biometric prompt canceled / incorrect error?
There's two biometric errors. Not sure if they're handled somewhere higher/ lower. It would probably be good if we can create a proof sharing pipeline at some point, that will be used for ALL proof sharing, and you can toggle the options that are needed. As with the offline / openid /dc api / whatever it's hard to keep everything in sync
paradym-wallet/packages/app/src/features/notifications/OpenIdPresentationNotificationScreen.tsx
Line 76 in c0f3eef
if (e instanceof BiometricAuthenticationCancelledError) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I test the biometrics flow? None of the funke flows seem to trigger it? Or do I need to be on secure enclave to test that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes secure env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay i handled it the same way as the other flows, but unable to test because secure env is broken.
Signed-off-by: Timo Glastra <[email protected]>
No description provided.