Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Added start time and an end time in Meetup. #523

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

satya7289
Copy link
Contributor

@satya7289 satya7289 commented Apr 16, 2020

Description

As the description of the issue, it requires that the meetup has a start time and end time. In this issue, I have made changes to support both start time and end time of the respective meetup.
I found 1 error while working on this issue that while logging out, it gives an error. I make changes to this to resolve the logout error.
I have modified and add the test cases to support my modified for start time and end time.

Fixes #432 #526

Type of Change:

  • Code
  • Quality Assurance
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I have tested it locally and modify test cases to support my changes.

Before changes, Meetup view looks like this.

Screenshot from 2020-04-16 12-35-55

After changes, Meetup view looks like this.

Screenshot from 2020-05-12 11-35-24


Before changes, Editing Meetup looks like this.

Screenshot from 2020-04-16 12-36-10

After changes, Editing Meetup looks like this.
Screenshot from 2020-05-13 13-33-32


Before changes, Adding Meetup looks like this.

Screenshot from 2020-04-16 12-36-16

After changes, Adding Meetup looks like this.

Screenshot from 2020-05-13 13-34-27


Before changes adding meetup via admin panel looks like this.

Screenshot from 2020-04-16 12-37-10

After changes adding meetup via admin panel looks like this.

Screenshot from 2020-05-13 13-35-20

Upcoming Meetup
Screenshot from 2020-05-12 11-35-35

I have also modified code for the logout button which faces some issue while logout.
Before while logging out gives an error.

Screenshot from 2020-04-16 12-36-29

After changes not giving such error.

Screenshot from 2020-04-16 12-50-50

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • I have modified some tests that prove my fix is effective or that my feature works
  • Modified and existing unit tests pass locally with my changes

@sammy1997
Copy link
Contributor

@satya7289 Why did you change the logout URL name? Also, if you have the start_time and end_time fields, what is the time field for?

@satya7289
Copy link
Contributor Author

@satya7289 Why did you change the logout URL name? Also, if you have the start_time and end_time fields, what is the time field for?

  1. The logout URL name is changed because while logging it gives the error which I attached above. Also while running test cases, it gives error here. Also, we are using Django-allauth so logout URL should be according to Django-allauth(account_logout).

  2. I don't add time field. But I guess it is for the duration of the event. I only add start_time, end_time, and time field is already there.
    @sammy1997

@sakshi1499
Copy link

@satya7289 I don't recommend changing the URL name in this PR. If the problem persists, we can open another issue on that. I also second @sammy1997 on the other point. Having a time field is redundant.

@rpattath rpattath added the Status: Needs Review PR needs an additional review or a maintainer's review. label Jun 1, 2020
@satya7289
Copy link
Contributor Author

Please let me know if this PR still needed.
@sakshi1499 @sammy1997 @SanketDG

@sakshi1499
Copy link

@satya7289 This PR is definitely relevant and We are making changes on this page through one of the other Prs.

@sakshi1499 sakshi1499 added Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating an end time and multi-day meetups
4 participants