You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the description of the issue, it requires that the meetup has a start time and end time. In this issue, I have made changes to support both start time and end time of the respective meetup.
I found 1 error while working on this issue that while logging out, it gives an error. I make changes to this to resolve the logout error.
I have modified and add the test cases to support my modified for start time and end time.
@satya7289 Why did you change the logout URL name? Also, if you have the start_time and end_time fields, what is the time field for?
The logout URL name is changed because while logging it gives the error which I attached above. Also while running test cases, it gives error here. Also, we are using Django-allauth so logout URL should be according to Django-allauth(account_logout).
I don't add time field. But I guess it is for the duration of the event. I only add start_time, end_time, and time field is already there. @sammy1997
@satya7289 I don't recommend changing the URL name in this PR. If the problem persists, we can open another issue on that. I also second @sammy1997 on the other point. Having a time field is redundant.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Status: On HoldIssue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the description of the issue, it requires that the meetup has a start time and end time. In this issue, I have made changes to support both start time and end time of the respective meetup.
I found 1 error while working on this issue that while logging out, it gives an error. I make changes to this to resolve the logout error.
I have modified and add the test cases to support my modified for start time and end time.
Fixes #432 #526
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
I have tested it locally and modify test cases to support my changes.
Before changes, Meetup view looks like this.
After changes, Meetup view looks like this.
Before changes, Editing Meetup looks like this.
After changes, Editing Meetup looks like this.
Before changes, Adding Meetup looks like this.
After changes, Adding Meetup looks like this.
Before changes adding meetup via admin panel looks like this.
After changes adding meetup via admin panel looks like this.
Upcoming Meetup
I have also modified code for the logout button which faces some issue while logout.
Before while logging out gives an error.
After changes not giving such error.
Checklist:
Code/Quality Assurance Only