Added OAuth Settings for Facebook

[ritwickraj78]

Description

Add the Settings for OAuth(Facebook)

Fixes #533

Type of Change:

Delete irrelevant options.

• Code

Code/Quality Assurance Only

• New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

The travis CI tests and all the local tests pass successfully and locally all third party authentications work properly.

Checklist:

Delete irrelevant options.

• [*] My PR follows the style guidelines of this project
• [*] I have performed a self-review of my own code or materials
• [*] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
• [*] Any dependent changes have been merged

Code/Quality Assurance Only

• [*] My changes generate no new warnings
• [*] New and existing unit tests pass locally with my changes

[satya7289]

@ritwickraj78 just a suggestion do create a PR with branch other than develop.

[sammy1997]

@ritwickraj78 For the remaining PRs please create a new branch for the PR. Don't use develop

[sammy1997]

LGTM!

[ritwickraj78]

Sure @sammy1997 I will keep that in mind. @SanketDG Could you have another look at it please?

[SanketDG]

After a fresh look, I have realized you don't need this setting at all.

Every setting just uses the default value except:

'AUTH_PARAMS': {'auth_type': 'reauthenticate'},

which just prompts for the password (I would personally vouch for not keeping this, since I have not seen this on popular sites' oAuth logins, but I am open to other views)

Unless we would want to implement specific niceties (good to have) of the oAuth implementation, it is mostly implemented and I have gone ahead and checked for atleast Facebook.

For production, all we need to is create the right SocialApp for the required providers, and all of it should be working.

Maybe others can pitch in on what needs to be done here, but you could write tests for the oAuth flow if there is nothing else you can work on right now.

[ritwickraj78]

@SanketDG So what should be done? If we don't need the re-authentication then we can close the PR then.

[SanketDG]

I am up for not making any changes at all and closing this, if others agree on this.

[sammy1997]

@SanketDG Sure. But should we close the linked issue as well or wait till May completes her part? @sakshi1499?

[sakshi1499]

@sammy1997 I agree. I think we should wait for May.

[SanketDG]

Did we follow up on this?

[ritwickraj78]

@SanketDG Not yet heard from May. Maybe tomorrow we can discuss in the meeting and then take the steps accordingly.

[sammy1997]

@SanketDG I spoke to @mayburgos in my 1:1 and she said she will have to talk to the IT team. SO it might take a while. Let's move forward for now!