Fix add_check_constraint when raising an error in safe mode #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaadow
force-pushed
the
fix_safe_default_check_constraint
branch
from
2e34975 to
35feb0d
Compare
Followup to ankane#271 When adding a CHECK constraint and safe mode is enabled: - we add a NOT VALID check constraint - then commit the transaction - and finally validate the check constraint in another migration. If the validation step fails, this leaves a NOT VALID check constraint in the database. If we retry after having cleaned up the database, the creation of the NOT VALID check constraint will fail because it will already be in the DB. This commit makes the migration safely retriable by checking if said check constraint already exists, and if so, skips its creation again.
chaadow
force-pushed
the
fix_safe_default_check_constraint
branch
from
35feb0d to
92c92f4
Compare
ankane
added a commit
that referenced
this pull request
Nov 7, 2024
Co-authored-by: chaadow <[email protected]>
|
Hey @chaadow, thanks for the PR. Merged a version in the commit above. I'm not sure about trying to clean up if the migration fails (as it'll introduce more locking), so excluding it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #271
When adding a CHECK constraint and safe mode is enabled:
If the validation step fails, this leaves a NOT VALID check constraint in the database.
If we retry after having cleaned up the database, the creation of the NOT VALID check constraint will fail because it will already be in the DB.
This commit makes the migration safely retriable by checking if said check constraint already exists, and if so, skips its creation again.