Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark DeckPicker context menu test flaky on windows #17977

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

mikehardy
Copy link
Member

@mikehardy mikehardy commented Feb 14, 2025

See Issue

This one is messing up my merge queue, driving me crazy.

Marking flaky

Had to de-conflict the "OS" symbol because something else appears to have been marked flaky, perhaps before we had a good annotation? Anyway, we have a good annotation now so I converted the previous windows cutout to a Flaky annotation

Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. Left a comment about an extra thing to investigate

@BrayanDSO BrayanDSO added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Feb 14, 2025
As Brayan rightly pointed out, relying entirely on our `Flaky.OS`
companion means we no longer have any uses at all of this dep
@mikehardy mikehardy removed the Needs Author Reply Waiting for a reply from the original author label Feb 15, 2025
@mikehardy mikehardy enabled auto-merge February 15, 2025 18:12
@mikehardy mikehardy added this pull request to the merge queue Feb 15, 2025
Merged via the queue into ankidroid:main with commit a5f97d8 Feb 15, 2025
9 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Feb 15, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants