Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Toolbar Visibility in Fullscreen Reviewer Mode #18025

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

theMr17
Copy link
Contributor

@theMr17 theMr17 commented Feb 26, 2025

Purpose / Description

This PR fixes the bug where the toolbar is hidden in semi-fullscreen reviewer.

Fixes

Approach

  • Updated FullScreenMode enum:
    • Renamed BUTTONS_ONLY to BUTTONS_AND_MENU_ONLY.
    • Renamed BUTTONS_AND_MENU to BUTTONS_AND_MENU_WITH_STATUS_BAR.
  • Added enableEdgeToEdge() in Reviewer.
  • Moved toolbar into the reviewer_fullscreen layout.
  • Moved answer buttons in reviewer_fullscreen_noanswers layout.
  • Updated fitsSystemWindows to exclude BUTTONS_AND_MENU_WITH_STATUS_BAR.
  • Updated fitsSystemWindows to true in reviewer_fullscreen_noanswers.xml to ensure that the card content does not get obscured by the camera cutout.
  • Removed fitsSystemWindows from reviewer_answer_buttons.
  • Update old fullscreenReview preference to use new enum.

How Has This Been Tested?

Fullscreen mode Reviewer Reviewer (answer revealed)
Off image image
Hide the system bars image image
Hide the system bars and answer buttons image image

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: "Hide the system bars" also hides the top ankidroid bar
1 participant