Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacker Card using Javascript #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ayushanand16
Copy link

Polyglot JS Task Submission

  • Checkpoint 1: Compare the cards of hacker and player.

20pts

  • Checkpoint 2: Keep a track of the individual scores of the hacker and player.

20pts

  • Checkpoint 3: Deploy the code to GitHub Pages.

10pts

  • Extras: You can improve UI of the game ;).

Submission

[Repo]https://github.com/ayushanand16/Polyglot_JS.git
[Deployed Site]https://ayushanand16.github.io/Polyglot_JS/

@Divyansh013
Copy link
Collaborator

@shubhangi013 review!

@shubhangi013
Copy link
Collaborator

@ayushanand16 Good work on the implementation! 🎊
There is however one edge case it isn't covering. When the 'power' of the cards are equal, (the statements however imply that one of the hacker or the user wins), the scores remain same. Please fix this.

@ayushanand16
Copy link
Author

Okay bhaiya

@shubhangi013
Copy link
Collaborator

LGTM 🎉
@Divyansh013 and @ankur12-1610 any reviews from your end?

@ankur12-1610
Copy link
Owner

LGTM 🎉
@Divyansh013 and @ankur12-1610 any reviews from your end?

Yeah LGTM!
Great work🙌

@Divyansh013
Copy link
Collaborator

LGTM 🎉 @Divyansh013 and @ankur12-1610 any reviews from your end?

Seems good @ayushanand16

@Divyansh013 Divyansh013 added the passed Great work label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
passed Great work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants