Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete functions #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Complete functions #23

wants to merge 1 commit into from

Conversation

EshaanAgg
Copy link

@EshaanAgg EshaanAgg commented Feb 13, 2022

Polyglot JS Task Submission

  • Checkpoint 1: Compare the cards of hacker and player.

20pts

  • Checkpoint 2: Keep a track of the individual scores of the hacker and player.

20pts

  • Checkpoint 3: Deploy the code to GitHub Pages.

10pts

  • Extras: You can improve UI of the game ;).

Submission

Repo https://github.com/EshaanAgg/Polyglot_JS
Deployed Site https://eshaanagg.github.io/Polyglot_JS/

  • I added two new scenarios (making the count 4 in total).
  • If a game lasts more than 4 turns, then the scenarios are looped back.
  • Changed the h1 tag containing the text 'HACKER CARDS' to show 'Game Over' at the appropriate time
  • Instead of showing only the powers of HackerCard and PlayerCard that were chosen, I decided to show powers for all the cards, as I found it more appealing

@shubhangi013
Copy link
Collaborator

@EshaanAgg amazing work! 🎉
Just a suggestion though, if you're looping over the scenarios, don't you think that revealing the power of all the cards makes it easier for the user to win?
Also, if possible, work with the CSS to align the winning and losing messages on smaller devices.

@EshaanAgg
Copy link
Author

Haha yes, you are right. But we can always say it was for "public awareness and education" reasons! XD
And yes, I'll definitely check how to work with CSS on smaller devices!

@Divyansh013
Copy link
Collaborator

Agreed on what Shubhangi said, you should not reveal the powers. Rest,Nice work @EshaanAgg

@Divyansh013 Divyansh013 added the passed Great work label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
passed Great work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants