Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logics in js #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added logics in js #3

wants to merge 2 commits into from

Conversation

amyra98
Copy link

@amyra98 amyra98 commented Feb 5, 2022

Polyglot JS Task Submission

  • Checkpoint 1: Compare the cards of hacker and player.

20pts

  • Checkpoint 2: Keep a track of the individual scores of the hacker and player.

20pts

  • Checkpoint 3: Deploy the code to GitHub Pages.

10pts

  • Extras: You can improve UI of the game ;).

Submission

Repo - https://github.com/amyra98/Polyglot_JS
Deployed Site- https://amyra98.github.io/Polyglot_JS/

@amyra98
Copy link
Author

amyra98 commented Feb 6, 2022

some more change

@amyra98 amyra98 closed this Feb 6, 2022
@ankur12-1610
Copy link
Owner

some more change

Ah! you don't need to close the PR :'), you can just commit the changes and push in the main branch, PR will automatically get updated.

@amyra98 amyra98 reopened this Feb 6, 2022
@Divyansh013
Copy link
Collaborator

All cards are getting loaded twice can you check? @amyra98

@Divyansh013 Divyansh013 self-requested a review February 6, 2022 12:10
@amyra98
Copy link
Author

amyra98 commented Feb 6, 2022

All cards are getting loaded twice can you check? @amyra98

Actually I added them twice so that I can see the scores for more rounds.

@amyra98 amyra98 closed this Feb 6, 2022
@amyra98 amyra98 reopened this Feb 6, 2022
@Divyansh013
Copy link
Collaborator

Also the game runs for a maximum of 4 turns only even if it's unfinished. Rest apart, nice work

@Divyansh013 Divyansh013 added the passed Great work label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
passed Great work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants